Skip to content

Conversation

parthchadha
Copy link
Contributor

What does this PR do ?

Eval.py did not support using async vllm engine which is required for pp.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
@parthchadha parthchadha changed the title Fix eval when using async engine fix: Fix eval when using async engine Jul 8, 2025
@parthchadha parthchadha added the CI:L0 Run doctests and unit tests label Jul 8, 2025
@github-actions github-actions bot added the CI Relating to CI label Jul 8, 2025
@parthchadha parthchadha enabled auto-merge July 8, 2025 20:57
@parthchadha parthchadha added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit dcb311e Jul 9, 2025
13 of 14 checks passed
@parthchadha parthchadha deleted the pchadha/eval-async-fix branch July 9, 2025 02:17
RayenTian pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
RayenTian pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
RayenTian pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
jialei777 pushed a commit to jialei777/nemo-rl that referenced this pull request Jul 23, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
@parthchadha parthchadha self-assigned this Aug 1, 2025
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:L0 Run doctests and unit tests CI Relating to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants