feat: Megatron MoE Support #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert of e01017a Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Guyue Huang <guyueh@nvidia.com> Run get_weights_for_ipc and get key map once for all Signed-off-by: Guyue Huang <guyueh@nvidia.com> Tag version that seems to be working Signed-off-by: Guyue Huang <guyueh@nvidia.com> Fix: use new weight param info every step Signed-off-by: Guyue Huang <guyueh@nvidia.com> Cleanup Signed-off-by: Guyue Huang <guyueh@nvidia.com> bugfix Signed-off-by: Guyue Huang <guyueh@nvidia.com> Add more time logs Signed-off-by: Guyue Huang <guyueh@nvidia.com> guyue/wip fix aggregated all gather objects fix aggregated all gather objects
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Delete self._held_gather_buffer Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
ashors1
previously approved these changes
Jul 3, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
terrykong
previously approved these changes
Jul 8, 2025
terrykong
approved these changes
Jul 9, 2025
RayenTian
pushed a commit
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com>
RayenTian
pushed a commit
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com>
RayenTian
pushed a commit
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: ruit <ruit@nvidia.com>
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information