Skip to content

Conversation

wedu-nvidia
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

add
drop_last=True
to prevent divisible error by dropping last batch in loader

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Wei Du <wedu@nvidia.com>
@wedu-nvidia wedu-nvidia force-pushed the wedu/fix-dataloader-droplast branch from 0cf209a to 9f8bef4 Compare June 30, 2025 21:32
@SahilJain314 SahilJain314 enabled auto-merge June 30, 2025 21:39
@SahilJain314 SahilJain314 added this pull request to the merge queue Jun 30, 2025
Merged via the queue into NVIDIA-NeMo:main with commit a249f3c Jun 30, 2025
12 of 14 checks passed
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 2, 2025
therealnaveenkamal pushed a commit to therealnaveenkamal/RL that referenced this pull request Jul 7, 2025
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jul 14, 2025
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants