Skip to content

fix: update gemma3 prefix #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

fix: update gemma3 prefix #585

merged 1 commit into from
Jul 1, 2025

Conversation

ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jun 30, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

Closes #453

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@ashors1
fix gemma3 prefix
14c5077 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 requested review from yfw and yuki-97 June 30, 2025 22:40
@ashors1 ashors1 marked this pull request as draft June 30, 2025 22:40
@ashors1 ashors1 marked this pull request as ready for review June 30, 2025 22:42
yfw
yfw approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@yfw yfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing!

@ashors1 ashors1 requested a review from terrykong June 30, 2025 22:55
@terrykong terrykong added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit c6b091d Jul 1, 2025
12 of 14 checks passed
@terrykong terrykong deleted the ashors/fix-gemma-it branch July 1, 2025 02:34
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 2, 2025
@ashors1 @xxman-google
fix: update gemma3 prefix (NVIDIA-NeMo#585)
2eb0301 
Signed-off-by: ashors1 <ashors@nvidia.com>
therealnaveenkamal pushed a commit to therealnaveenkamal/RL that referenced this pull request Jul 7, 2025
@ashors1 @therealnaveenkamal
fix: update gemma3 prefix (NVIDIA-NeMo#585)
1d55747 
Signed-off-by: ashors1 <ashors@nvidia.com>
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jul 14, 2025
@ashors1
fix: update gemma3 prefix (NVIDIA-NeMo#585)
1dd7848 
Signed-off-by: ashors1 <ashors@nvidia.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
@ashors1 @KiddoZhu
fix: update gemma3 prefix (#585)
6682418 
Signed-off-by: ashors1 <ashors@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfw yfw yfw approved these changes

@parthchadha parthchadha parthchadha approved these changes

@yuki-97 yuki-97 Awaiting requested review from yuki-97

@terrykong terrykong Awaiting requested review from terrykong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gemma-3-4b-it failed on 'Gemma3TextModel' object has no attribute 'model'
4 participants
@ashors1 @yfw @parthchadha @terrykong