Skip to content

Conversation

ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jun 27, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

Closes #441

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

ashors1 added 2 commits June 27, 2025 12:20
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 requested a review from terrykong June 27, 2025 19:25
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 marked this pull request as ready for review June 27, 2025 20:04
Signed-off-by: ashors1 <ashors@nvidia.com>
@terrykong terrykong enabled auto-merge July 4, 2025 04:11
terrykong
terrykong previously approved these changes Jul 9, 2025
@terrykong terrykong added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
@terrykong terrykong added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 92fc7d7 Jul 10, 2025
13 of 14 checks passed
@terrykong terrykong deleted the ashors/ckpt-without-validation branch July 10, 2025 01:35
RayenTian pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
RayenTian pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>

add the implementation of cons@k

Modify pass_k_value to k_value, unify the parameters of pass@k and cons@k

Signed-off-by: ruit <ruit@nvidia.com>
RayenTian pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>

add the implementation of cons@k

Modify pass_k_value to k_value, unify the parameters of pass@k and cons@k

Signed-off-by: ruit <ruit@nvidia.com>
jialei777 pushed a commit to jialei777/nemo-rl that referenced this pull request Jul 23, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow saving checkpoints in sft without running validation
2 participants