fix: Add assertion if async is disabled when using pp with vllm #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
terrykong
approved these changes
Jun 26, 2025
SahilJain314
approved these changes
Jun 26, 2025
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 27, 2025
…IA-NeMo#565) Signed-off-by: Parth Chadha <pchadha@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 27, 2025
…IA-NeMo#565) Signed-off-by: Parth Chadha <pchadha@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 30, 2025
…IA-NeMo#565) Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 30, 2025
…IA-NeMo#565) Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
therealnaveenkamal
pushed a commit
to therealnaveenkamal/RL
that referenced
this pull request
Jul 7, 2025
…IA-NeMo#565) Signed-off-by: Parth Chadha <pchadha@nvidia.com>
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jul 14, 2025
…IA-NeMo#565) Signed-off-by: Parth Chadha <pchadha@nvidia.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…IA-NeMo#565) Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information