feat: guide to configure custom vllm version #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d90118a to
9f163b1
Compare
SahilJain314
previously approved these changes
Jun 27, 2025
jgerh
reviewed
Jun 30, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> script for debugging Signed-off-by: Terry Kong <terryk@nvidia.com> clean up Signed-off-by: Terry Kong <terryk@nvidia.com> add it into the index Signed-off-by: Terry Kong <terryk@nvidia.com> fix tutorial Signed-off-by: Terry Kong <terryk@nvidia.com> comment on why setuptools_scm Signed-off-by: Terry Kong <terryk@nvidia.com> clarify Signed-off-by: Terry Kong <terryk@nvidia.com> fix Signed-off-by: Terry Kong <terryk@nvidia.com> copyright Signed-off-by: Terry Kong <terryk@nvidia.com> Apply suggestions from code review Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Apply suggestions from code review Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Update docs/guides/use-custom-vllm.md Signed-off-by: Terry Kong <terrycurtiskong@gmail.com>
parthchadha
approved these changes
Jul 9, 2025
RayenTian
pushed a commit
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
RayenTian
pushed a commit
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
RayenTian
pushed a commit
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: ruit <ruit@nvidia.com>
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some models require testing a fix from vllm that's not in a released branch. This change adds a script that builds vllm as well as a guide that shows how to configure NeMo RL to use it