Allow uneven shards for multi-GPU inference in vllm backend #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KiddoZhu <zhaochengz@nvidia.com>
Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
SahilJain314
approved these changes
Jun 26, 2025
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 27, 2025
…eMo#494) Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 27, 2025
…eMo#494) Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 30, 2025
…eMo#494) Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: Xuehan <xxman@google.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 30, 2025
…eMo#494) Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: Xuehan <xxman@google.com>
therealnaveenkamal
pushed a commit
to therealnaveenkamal/RL
that referenced
this pull request
Jul 7, 2025
…eMo#494) Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jul 14, 2025
…eMo#494) Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
KiddoZhu
added a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…eMo#494) Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
generate_textin vllm backend requires every batch to be sharded evenly across multiple GPUs. This prevents one from running evaluation on dataset that is not divisible by the number of GPUs.