Skip to content

Conversation

ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jun 5, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@ashors1 ashors1 requested review from yfw and terrykong June 5, 2025 04:31
@ashors1 ashors1 changed the title Add missing 'add_generation_prompt' key to SFT convergence tests fix: Add missing 'add_generation_prompt' key to SFT convergence tests Jun 5, 2025
@terrykong terrykong added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit 99ba9a1 Jun 5, 2025
13 of 16 checks passed
@terrykong terrykong deleted the ashors/fix_sft_convergence_tests branch June 5, 2025 17:10
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants