Skip to content

Conversation

chtruong814
Copy link
Contributor

What does this PR do ?

Set codecov override_branch to main if from merge queue.

The codecov upload works, but when it's ran during a merge queue, it uses the temporary branch as the name. We should just set this to 'main'.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@github-actions github-actions bot added the CI Relating to CI label May 22, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@terrykong terrykong enabled auto-merge May 22, 2025 18:59
@terrykong terrykong added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit fbad37c May 22, 2025
13 of 14 checks passed
@terrykong terrykong deleted the chtruong/fix-codecov branch May 22, 2025 20:03
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
…eMo#437)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Relating to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants