Skip to content

ci: Upload codecov #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2025
Merged

ci: Upload codecov #423

merged 5 commits into from
May 21, 2025

Conversation

chtruong814
Copy link
Contributor

What does this PR do ?

ci: Upload codecov

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@github-actions github-actions bot added the CI Relating to CI label May 20, 2025
@chtruong814 chtruong814 added the CI:L0 Run doctests and unit tests label May 20, 2025
@chtruong814 chtruong814 removed the CI:L0 Run doctests and unit tests label May 20, 2025
@chtruong814
ci: Upload codecov
6cdef4c 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added the CI:L0 Run doctests and unit tests label May 20, 2025
terrykong
terrykong previously approved these changes May 20, 2025
View reviewed changes
@chtruong814
Use relative_files for code coverage
a424075 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 21, 2025
@chtruong814
Use codecov.yml
896d841 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 21, 2025
@chtruong814
Fix the coverage.json file for codecov
0789b85 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 21, 2025
@chtruong814
Fix codecov
cd0f787 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 21, 2025
@terrykong terrykong added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit d6e613a May 21, 2025
21 checks passed
@terrykong terrykong deleted the chtruong/codecov branch May 21, 2025 23:32
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
@chtruong814
ci: Upload codecov (NVIDIA-NeMo#423)
5fb6b38 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

Assignees
No one assigned
Labels
CI:L0 Run doctests and unit tests CI Relating to CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chtruong814 @terrykong