Skip to content

feat: default to UV_CACHE_DIR from within the container #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

feat: default to UV_CACHE_DIR from within the container #427

merged 1 commit into from
May 29, 2025

Conversation

terrykong
Copy link
Contributor

@terrykong terrykong commented May 21, 2025 •
edited
Loading

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Our instructions for UV_CACHE_DIR are outdated. This PR updates them, but also defaults to using the UV_CACHE_DIR within the container. The old behavior is still supported via UV_CACHE_DIR_OVERRIDE, but it saves disk space during experimentation not having to create multiple UV_CACHE_DIRs for each experiment.

Will wait for #410 to go in since this doc change is based on that PRs doc change.

Issues

List issues that this PR closes (syntax):

Closes #426

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 21, 2025
@terrykong terrykong requested review from yuki-97, SahilJain314 and parthchadha and removed request for yuki-97 May 21, 2025 07:19
@terrykong terrykong force-pushed the use-default-uvcache branch 2 times, most recently from 4415e55 to c06ba88 Compare May 23, 2025 23:42
@terrykong
wip
840532d 
Signed-off-by: Terry Kong <terryk@nvidia.com>

fix it

Signed-off-by: Terry Kong <terryk@nvidia.com>

make it match

Signed-off-by: Terry Kong <terryk@nvidia.com>

fix it all

Signed-off-by: Terry Kong <terryk@nvidia.com>

cleanup

Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong force-pushed the use-default-uvcache branch from 8482771 to 840532d Compare May 27, 2025 05:10
@terrykong terrykong requested a review from jgerh May 27, 2025 05:20
jgerh
jgerh reviewed May 27, 2025
View reviewed changes
@terrykong terrykong added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit ab1b638 May 29, 2025
13 of 14 checks passed
@terrykong terrykong deleted the use-default-uvcache branch May 29, 2025 19:17
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
@terrykong
feat: default to UV_CACHE_DIR from within the container (NVIDIA-NeMo#427
cb0edd1 
)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgerh jgerh jgerh left review comments

@parthchadha parthchadha parthchadha approved these changes

@SahilJain314 SahilJain314 Awaiting requested review from SahilJain314

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change UV_CACHE_DIR to within container for slurm script
3 participants
@terrykong @parthchadha @jgerh