Skip to content

Conversation

parthchadha
Copy link
Contributor

Make dtensor default in 8b config; fixes broken example in README fo multinode

What does this PR do ?

README example for multinode was broken:

assert config["dtensor_cfg"]["enabled"], (           ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
AssertionError: Dynamic batch is only supported for DTensor policy.

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

… multinode

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
@parthchadha parthchadha requested a review from terrykong May 16, 2025 20:27
@terrykong terrykong changed the title Make dtensor default in 8b config fix Make dtensor default in 8b config May 16, 2025
@terrykong terrykong added this pull request to the merge queue May 16, 2025
@parthchadha parthchadha changed the title fix Make dtensor default in 8b config fix: Make dtensor default in 8b config May 16, 2025
Merged via the queue into main with commit 3309631 May 16, 2025
13 of 17 checks passed
@terrykong terrykong deleted the pchadha/dtensor-default branch May 16, 2025 21:52
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants