-
Notifications
You must be signed in to change notification settings - Fork 117
feat: add deepscaler guide #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
I think we should maybe have this highlighted on the front page readme with a heading (maybe above the Features
heading here so it stands out: https://github.com/NVIDIA/NeMo-RL/blob/6c1794f7ebff938c6c8efeb7f481006e9aaf9563/README.md?plain=1#L35)
## 📣 News
* [5/14/2025] [Reproduce DeepscaleR with NeMo RL!](link-to-this-markdown)
Also, after #360 goes in, I think this should also be added to the sidebar under this section https://github.com/NVIDIA/NeMo-RL/blob/6c1794f7ebff938c6c8efeb7f481006e9aaf9563/docs/index.md?plain=1#L15
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed the review of README.md and docs/guides/grpo_deepscaler.md and provided a few copyedits.
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome,lgtm
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Adds deepscaler guide
Issues
List issues that this PR closes (syntax):
Usage
Before your PR is "Ready for review"
Pre checks:
Additional Information