Skip to content

Conversation

abukharin-nv
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.
Adds deepscaler guide

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
uv run examples/run_grpo_math.py --config=examples/configs/grpo-deepscaler-1.5b-8K.yaml
uv run examples/run_grpo_math.py --config=examples/configs/grpo-deepscaler-1.5b-16K.yaml
uv run examples/run_grpo_math.py --config=examples/configs/grpo-deepscaler-1.5b-24K.yaml

Before your PR is "Ready for review"

Pre checks:

  • [Y] Make sure you read and followed Contributor guidelines
  • [N] Did you write any new necessary tests?
  • [Y] Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • [Y] Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: abukharin-nv <abukharin@nvidia.com>
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 15, 2025
Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

I think we should maybe have this highlighted on the front page readme with a heading (maybe above the Features heading here so it stands out: https://github.com/NVIDIA/NeMo-RL/blob/6c1794f7ebff938c6c8efeb7f481006e9aaf9563/README.md?plain=1#L35)

## 📣 News
* [5/14/2025] [Reproduce DeepscaleR with NeMo RL!](link-to-this-markdown)

Also, after #360 goes in, I think this should also be added to the sidebar under this section https://github.com/NVIDIA/NeMo-RL/blob/6c1794f7ebff938c6c8efeb7f481006e9aaf9563/docs/index.md?plain=1#L15

Signed-off-by: abukharin-nv <abukharin@nvidia.com>
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
Copy link
Contributor

@jgerh jgerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the review of README.md and docs/guides/grpo_deepscaler.md and provided a few copyedits.

Signed-off-by: abukharin-nv <abukharin@nvidia.com>
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
parthchadha
parthchadha previously approved these changes May 15, 2025
Copy link
Contributor

@SahilJain314 SahilJain314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome,lgtm

@terrykong terrykong added this pull request to the merge queue May 15, 2025
@terrykong terrykong linked an issue May 15, 2025 that may be closed by this pull request
3 tasks
Merged via the queue into main with commit f4e95ab May 15, 2025
13 checks passed
@terrykong terrykong deleted the abukharin/deepscaler-demo branch May 15, 2025 18:13
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
Signed-off-by: abukharin-nv <abukharin@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation r0.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deepscaler convergence
5 participants