Skip to content

Conversation

ashors1
Copy link
Contributor

@ashors1 ashors1 commented May 9, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 requested a review from terrykong May 9, 2025 00:37
@ashors1 ashors1 added the CI:L1 Run doctests, unit tests, and functional tests label May 9, 2025
terrykong
terrykong previously approved these changes May 9, 2025
@terrykong terrykong enabled auto-merge May 9, 2025 00:47
@terrykong terrykong added this pull request to the merge queue May 9, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 removed this pull request from the merge queue due to a manual request May 9, 2025
@terrykong terrykong added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 6dd1b57 May 9, 2025
13 checks passed
@terrykong terrykong deleted the ashors/fix-dpo-functional-test branch May 9, 2025 04:51
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:L1 Run doctests, unit tests, and functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants