fix: sliding_window_overwrite #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
SahilJain314
reviewed
May 7, 2025
parthchadha
reviewed
May 7, 2025
Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: ZhiyuLi-Nvidia <zhiyul@NVIDIA.com>
Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: ZhiyuLi-Nvidia <zhiyul@NVIDIA.com>
Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
parthchadha
approved these changes
May 8, 2025
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jun 10, 2025
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: ZhiyuLi-Nvidia <zhiyul@NVIDIA.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Address sliding_window issue in reproducing deepscaler experiments with
deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B. Given the bug from upstream hf, overwrite it in hf model initialization.Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information