feat: Total worker isolation (avoid imports of worker deps in base environment) #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrykong
requested changes
May 6, 2025
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
…ng all actors it created (and creating a scoping nightmare) Signed-off-by: Sahil Jain <sahilj@nvidia.com>
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
1297169 to
3defc9d
Compare
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
|
Of note: #408 |
parthchadha
previously approved these changes
May 16, 2025
terrykong
reviewed
May 16, 2025
terrykong
reviewed
May 16, 2025
terrykong
reviewed
May 16, 2025
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
terrykong
reviewed
May 16, 2025
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
terrykong
previously approved these changes
May 17, 2025
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
parthchadha
approved these changes
May 19, 2025
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jun 10, 2025
…vironment) (NVIDIA-NeMo#321) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.