Skip to content

ci: Migrate to use cuda image as base for container #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 13, 2025
Merged

ci: Migrate to use cuda image as base for container #312

merged 8 commits into from
May 13, 2025

Conversation

chtruong814
Copy link
Contributor

What does this PR do ?

Migrate to use cuda image as base for container

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@chtruong814
Migrate to use cuda image as base for container
deb45d7 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added the CI:L0 Run doctests and unit tests label May 3, 2025
@chtruong814
Install git in test container
86404af 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 3, 2025
@chtruong814
Use cuda 12.5.1 base image
745744b 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 3, 2025
@chtruong814
Add gcc to docker container
2893171 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 3, 2025
@chtruong814
Update cuda base image
c78f7ca 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 3, 2025
@chtruong814
Use cuda-devel base image
ca4cfa5 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L0 Run doctests and unit tests CI:L1 Run doctests, unit tests, and functional tests and removed CI:L0 Run doctests and unit tests labels May 3, 2025
@chtruong814 chtruong814 requested a review from terrykong May 4, 2025 11:19
terrykong
terrykong reviewed May 5, 2025
View reviewed changes
terrykong
terrykong reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chtruong814 could you try this dockerfile with this feature #308 ? I'm curious if the way I've wrangled the megatron environment is compatible with this new base image

@chtruong814
Copy link
Contributor Author

@terrykong fwiw, I could build the docker image with the mcore extra in that other PR using the cuda base image from this PR.

chtruong814 added 2 commits May 5, 2025 22:21
@chtruong814
Remove unnecessary chown for ray user in dockerfile
516dc86 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Merge remote-tracking branch 'origin/main' into chtruong/migrate-dock…
aa68138 
…er-cuda

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels May 12, 2025
@terrykong terrykong added this pull request to the merge queue May 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025
@chtruong814 chtruong814 added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit edfd362 May 13, 2025
21 checks passed
@chtruong814 chtruong814 deleted the chtruong/migrate-docker-cuda branch May 13, 2025 21:17
terrykong pushed a commit that referenced this pull request May 15, 2025
@chtruong814 @terrykong
ci: Migrate to use cuda image as base for container (#312)
24d8a5d 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@terrykong terrykong linked an issue May 20, 2025 that may be closed by this pull request
Switch from anyscale to cuda base image #304
Closed
@terrykong terrykong mentioned this pull request May 20, 2025
Closed
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
@chtruong814
ci: Migrate to use cuda image as base for container (NVIDIA-NeMo#312)
c6d8c6b 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

Assignees
No one assigned
Labels
CI:L1 Run doctests, unit tests, and functional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from anyscale to cuda base image
2 participants
@chtruong814 @terrykong