Skip to content

test: switch tests to qwen3 0.6B #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 8, 2025
Merged

test: switch tests to qwen3 0.6B #315

merged 7 commits into from
May 8, 2025

Conversation

terrykong
Copy link
Contributor

@terrykong terrykong commented May 5, 2025 •
edited
Loading

@terrykong terrykong added the CI:L1 Run doctests, unit tests, and functional tests label May 5, 2025
@github-actions github-actions bot added the CI Relating to CI label May 5, 2025
@terrykong terrykong mentioned this pull request May 5, 2025
Closed
parthchadha
parthchadha previously approved these changes May 5, 2025
View reviewed changes
@terrykong
Copy link
Contributor Author

tests pass locally, but CI fails on some expected generations. need to look into

SahilJain314
SahilJain314 reviewed May 5, 2025
View reviewed changes
@terrykong terrykong added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels May 7, 2025
parthchadha
parthchadha previously approved these changes May 7, 2025
View reviewed changes
@terrykong terrykong added this pull request to the merge queue May 7, 2025
@terrykong terrykong linked an issue May 7, 2025 that may be closed by this pull request
Improve slow unit tests #184
Closed
@terrykong terrykong removed a link to an issue May 7, 2025
Improve slow unit tests #184
Closed
@terrykong
Copy link
Contributor Author

related to #184

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2025
SahilJain314
SahilJain314 previously approved these changes May 7, 2025
View reviewed changes
@terrykong terrykong dismissed stale reviews from SahilJain314 and parthchadha via a647407 May 7, 2025 20:41
terrykong added 4 commits May 7, 2025 13:44
@terrykong
test: switch tests to qwen3 0.6B
9c094f4 
Signed-off-by: Terry Kong <terryk@nvidia.com>

go

Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
fix up vllm tests
780faba 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
fix stop word tests on fsdp1 tests too
101868d 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
slim down sft test
58eb657 
Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong added 2 commits May 7, 2025 13:54
@terrykong
fix dpo
39cd6d7 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
make grpo and grpo_multiturn smaller too
4bac063 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong enabled auto-merge May 7, 2025 21:29
SahilJain314
SahilJain314 previously approved these changes May 7, 2025
View reviewed changes
@terrykong terrykong added this pull request to the merge queue May 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2025
@terrykong
update tolerance
b13b9ed 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@SahilJain314 SahilJain314 added this pull request to the merge queue May 8, 2025
@SahilJain314 SahilJain314 removed this pull request from the merge queue due to a manual request May 8, 2025
@terrykong terrykong added this pull request to the merge queue May 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 8, 2025
@terrykong terrykong added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 5ef624b May 8, 2025
13 checks passed
@terrykong terrykong deleted the tk/test-qwen0.6 branch May 8, 2025 03:41
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
@terrykong
test: switch tests to qwen3 0.6B (NVIDIA-NeMo#315)
6610cfc 
Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SahilJain314 SahilJain314 SahilJain314 approved these changes

@parthchadha parthchadha parthchadha left review comments

Assignees
No one assigned
Labels
CI:L1 Run doctests, unit tests, and functional tests CI Relating to CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrykong @parthchadha @SahilJain314