Skip to content

feat: config.json -> config.yaml to keep configs in the same representation #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

terrykong
Copy link
Contributor

To convert your existing configs:

yq -P eval config.json > config.yaml

…tation

To convert your existing configs:
```sh
yq -P eval config.json > config.yaml
```

Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong requested a review from SahilJain314 May 4, 2025 23:22
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 4, 2025
@terrykong terrykong added CI:L0 Run doctests and unit tests and removed documentation Improvements or additions to documentation labels May 4, 2025
@terrykong terrykong added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 40a42e2 May 5, 2025
21 checks passed
@terrykong terrykong deleted the tk/config-yaml branch May 5, 2025 06:38
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
…tation (NVIDIA-NeMo#314)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:L0 Run doctests and unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants