Skip to content

fix: Step LR scheduler once per grpo step #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

fix: Step LR scheduler once per grpo step #305

merged 3 commits into from
May 5, 2025

Conversation

ashors1
Copy link
Contributor

@ashors1 ashors1 commented May 2, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@ashors1
step the scheduler once per grpo step
23280ba 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
update convergence recipes
a986eb0 
Signed-off-by: ashors1 <ashors@nvidia.com>
SahilJain314
SahilJain314 previously approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@SahilJain314 SahilJain314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

parthchadha
parthchadha reviewed May 2, 2025
View reviewed changes
parthchadha
parthchadha previously approved these changes May 2, 2025
View reviewed changes
terrykong
terrykong reviewed May 2, 2025
View reviewed changes
@terrykong terrykong dismissed stale reviews from parthchadha and SahilJain314 via a4d1c1a May 5, 2025 16:23
@terrykong
Update examples/configs/grpo_math_8B.yaml
a4d1c1a 
Signed-off-by: Terry Kong <terrycurtiskong@gmail.com>
@terrykong terrykong enabled auto-merge May 5, 2025 16:47
@terrykong terrykong added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 3276f8f May 5, 2025
13 checks passed
@terrykong terrykong deleted the ashors/update-lr-step branch May 5, 2025 19:59
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
@ashors1 @terrykong
fix: Step LR scheduler once per grpo step (NVIDIA-NeMo#305)
696b511 
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Terry Kong <terrycurtiskong@gmail.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

@parthchadha parthchadha parthchadha left review comments

@SahilJain314 SahilJain314 SahilJain314 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashors1 @terrykong @parthchadha @SahilJain314