-
Notifications
You must be signed in to change notification settings - Fork 117
feat: remove manual refit param #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b93a90b
to
1b9370b
Compare
cd441a4
to
a79e59c
Compare
474102b
to
42d00c4
Compare
42d00c4
to
37dea12
Compare
terrykong
reviewed
May 30, 2025
66b2bb3
to
99a6e3d
Compare
This reverts commit ef530fb. Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
99a6e3d
to
4e45bbd
Compare
terrykong
approved these changes
Jun 4, 2025
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jun 10, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Compute
refit_buffer_size_gb
by remaining memory at refitting process instead of manually set it.I kept
refit_buffer_size_gb
param atrefit_policy_generation()
andprepare_weights_for_ipc()
only for unit test, and removed it at any other places.Issues
Closes #249
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
Additional Information