Skip to content

Conversation

yuki-97
Copy link
Contributor

@yuki-97 yuki-97 commented Apr 29, 2025

What does this PR do ?

Compute refit_buffer_size_gb by remaining memory at refitting process instead of manually set it.

I kept refit_buffer_size_gb param at refit_policy_generation() and prepare_weights_for_ipc() only for unit test, and removed it at any other places.

Issues

Closes #249

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@yuki-97 yuki-97 added the CI:L1 Run doctests, unit tests, and functional tests label Apr 29, 2025
@yuki-97 yuki-97 force-pushed the yukih/remove-refit-param branch from b93a90b to 1b9370b Compare April 29, 2025 13:23
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Apr 29, 2025
@yuki-97 yuki-97 force-pushed the yukih/remove-refit-param branch 3 times, most recently from cd441a4 to a79e59c Compare May 6, 2025 11:55
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels May 6, 2025
@yuki-97 yuki-97 force-pushed the yukih/remove-refit-param branch 4 times, most recently from 474102b to 42d00c4 Compare May 28, 2025 07:25
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels May 28, 2025
@yuki-97 yuki-97 marked this pull request as ready for review May 28, 2025 09:40
@yuki-97 yuki-97 force-pushed the yukih/remove-refit-param branch from 42d00c4 to 37dea12 Compare May 29, 2025 11:10
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels May 29, 2025
@yuki-97 yuki-97 force-pushed the yukih/remove-refit-param branch 2 times, most recently from 66b2bb3 to 99a6e3d Compare May 30, 2025 07:32
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels May 30, 2025
yuki-97 added 7 commits June 3, 2025 20:03
This reverts commit ef530fb.

Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97 yuki-97 force-pushed the yukih/remove-refit-param branch from 99a6e3d to 4e45bbd Compare June 4, 2025 03:04
@terrykong terrykong added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 0a20df1 Jun 4, 2025
13 of 14 checks passed
@terrykong terrykong deleted the yukih/remove-refit-param branch June 4, 2025 05:14
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:L1 Run doctests, unit tests, and functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove refit_buffer_size_gb
2 participants