Skip to content

fix: fix issues preventing running grpo on volta #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 12, 2025
Merged

fix: fix issues preventing running grpo on volta #294

merged 7 commits into from
May 12, 2025

Conversation

parthchadha
Copy link
Contributor

@parthchadha parthchadha commented Apr 29, 2025 •
edited
Loading

What does this PR do ?

Screenshot 2025-05-12 at 10 08 59 AM

Add a one line overview of what this PR aims to accomplish.

Issues

Closes #259.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@parthchadha parthchadha added the CI:L0 Run doctests and unit tests label Apr 29, 2025
@parthchadha
fix: fix issues preventing running grpo on volta
b7b1969 
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
terrykong
terrykong reviewed Apr 30, 2025
View reviewed changes
SahilJain314
SahilJain314 reviewed May 5, 2025
View reviewed changes
@parthchadha parthchadha added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels May 8, 2025
terrykong
terrykong previously approved these changes May 9, 2025
View reviewed changes
@parthchadha parthchadha added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@parthchadha parthchadha enabled auto-merge May 12, 2025 20:18
@parthchadha parthchadha added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit 0a674bb May 12, 2025
13 checks passed
@parthchadha parthchadha deleted the pchadha/volta-fix branch May 12, 2025 22:01
terrykong pushed a commit that referenced this pull request May 15, 2025
@parthchadha @terrykong
fix: fix issues preventing running grpo on volta (#294)
0313e68 
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jun 10, 2025
@parthchadha
fix: fix issues preventing running grpo on volta (NVIDIA-NeMo#294)
1629856 
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SahilJain314 SahilJain314 SahilJain314 left review comments

@terrykong terrykong terrykong approved these changes

Assignees
No one assigned
Labels
CI:L0 Run doctests and unit tests r0.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V100 (compute capability 7.0) fails with default bfloat16 in vLLM — should fall back to float16 or be configurable via vllm_cfg
3 participants
@parthchadha @terrykong @SahilJain314