fix: host ip resolution uses ray vs socket #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthchadha
approved these changes
Apr 9, 2025
SahilJain314
approved these changes
Apr 9, 2025
|
@SahilJain314 Yea, there was an interesting bug someone ran into on NGC where the pod they were given had a hostname that was literally an integer like Ray has an API to grab ip address, so that seemed like a better offering. Tested on the bug reporter's NGC machine that this works. |
parthchadha
pushed a commit
that referenced
this pull request
Apr 11, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Parth Chadha <pchadha@nvidia.com>
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.