Skip to content

Conversation

chtruong814
Copy link
Contributor

What does this PR do ?

Add DCO placeholder check for merge queue

We require the DCO status check on PRs to main. However, this does not work by default with merge queues because the DCO check happens on PRs only. And merge queues operate on temporary branches, so the merge queue will never succeed without the required DCO check.

So, we create a placeholder DCO check that does nothing but satisfy the required status check in merge queues. The real check will still happen on PRs.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested a review from terrykong April 8, 2025 02:46
@github-actions github-actions bot added the CI Relating to CI label Apr 8, 2025
@terrykong terrykong merged commit 80a082a into main Apr 8, 2025
12 checks passed
@terrykong terrykong deleted the chtruong/dco-merge-queue branch April 8, 2025 19:33
parthchadha pushed a commit that referenced this pull request Apr 11, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
KiddoZhu pushed a commit that referenced this pull request May 6, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Relating to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants