Skip to content

Fixed path for NUGET_PACKAGE env var under Windows 10 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

vader1986
Copy link

On my machine Windows 10 is storing nuget packages right into the folder NUGET_PACKAGE points to, rather than the packages subfolder. Hopefully this compiles (just used the GitHub edit function without any testing).

On my machine Windows 10 is storing nuget packages right into the folder `NUGET_PACKAGE` points to, rather than the `packages` subfolder.
@JohannesHoppe
Copy link
Member

I would have a better feeling if you could test this first on your machine! 😉

@vader1986
Copy link
Author

Fair enough, might give it a go after work, just need to clone the repo & get it build.

@vader1986
Copy link
Author

Okay, that definitely fixed it for me!

Also, I had a quick look into the docs, I couldn't find a place which indicates that packages are stored in a "packages" sub-directory when the NUGET_PACKAGES variable is set. But maybe that behavior changed over time.

@JohannesHoppe
Copy link
Member

JohannesHoppe commented Apr 28, 2021

I don't know, this was just recently pushed by @bastianeicher via #110 ! 🤷🏻‍♂️

@vader1986
Copy link
Author

Probably worth keeping both in, just to be sure. This definitely works for me and I doubt that it breaks anything.
For now, I just worked around it by using a custom search pattern (which is not super-nice).

@JohannesHoppe JohannesHoppe merged commit 9b82f6c into Mongo2Go:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants