Changes to return_types field #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes definition and field type for return_type enum
renames return_type to return_constraint
|
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on January 29, 2022. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
|
+1 From transit |
|
+1 From Google Maps, we don't ingest it yet but it definitely makes for a less ambiguous spec. |
|
+1 from Entur |
|
+1 from Spin |
|
This vote has now closed, and it passes! Votes in favor: |
isabelle-dr
added a commit
to MobilityData/gbfs-json-schema
that referenced
this pull request
Mar 10, 2022
Updated after modifications in MobilityData/gbfs#400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’ve discovered an issue with a field that was added in v2.3RC and it's significant enough that we'd like to fix it before the v2.3RC2 and v3.0RC release candidates are completed. The issue is with the
return_typefield that describes constraints placed on the return of vehicles at the end of a rental. The field was defined as an array of enums which allowed multiple constraints to be placed on a vehicle. The problem is that the enums as defined were exclusive and not able to be combined, for example a vehicle can’t be both free floating and be required to be returned to a station. To fix this I’ve changed the field from an array of enums to a simple enum, and added an option for hybrid systems where vehicles can be returned to stations or free floating. I’ve also renamed the field fromreturn_typetoreturn_constraintas was suggested in #329.We plan to call a vote on this proposal on January 18th. Please submit any feedback before then.