Voight Kampff Integration Test Succeeded (Results)

Looks nice and simple! Will test it properly tonight or tomorrow

Two things:

• Docstrings are missing
• is there a reason you're using a custom response message type and not message.response(...) to generate the default response message with the default type? (assuming it has something to do with using reply...)

Nice! Are you guys still trying to maintain anything like this list of messages that traverse the messagebus?
https://docs.google.com/spreadsheets/d/1RsBpMOGx4o8A_zF_UELYQSLK8DlIScHGnfzJ3iSN0AE/edit#gid=0

I never loved using a Google Sheet for this (outside of the repo), but having something like this seems useful.

@krisgesling @chrisveilleux

Hey @penrods I have moved that list of message types to the public documentation and trying to keep it updated there instead:
https://mycroft-ai.gitbook.io/docs/mycroft-technologies/mycroft-core/message-types

It's a good point that we need to add in the gui.* messages though

* is there a reason you're using a custom response message type and not `message.response(...)` to generate the default response message with the default type? (assuming it has something to do with using reply...)

because of message context, needs to use .reply for proper targeting/hivemind routing, but i would argue that message.response should be refactored to use this internally self.reply(xxxx) instead of ```response_message = Message(xxxx)``.

It can't always do that, since it is sometimes used within a service (I did change it briefly when merging your updates for the reply but it broke things severely when chained messages were emitted). I do think we should have an optional reply flag to the response however.

For now can maybe we can change the response message type to match the default response? gui.status.request.response?

Voight Kampff Integration Test Succeeded (Results)

Should also have said, beyond the little question above, I think this is great. Definitely going to be needed very soon.

Voight Kampff Integration Test Succeeded (Results)

Should also have said, beyond the little question above, I think this is great. Definitely going to be needed very soon.

i already need it xD

Voight Kampff Integration Test Failed (Results)

Voight Kampff Integration Test Succeeded (Results)