Skip to content

Checking for the subscription detached payment method #4565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Aug 7, 2025

Fixes STRIPE-661
Thread https://wordpress.org/support/topic/removing-unwanted-detached-payment-method-notices/

Changes proposed in this Pull Request:

Currently, the subscription detached notice displayed in the admin interface for subscriptions without payment methods does not verify the gateway. This causes notices to be shown erroneously for merchants with multiple gateways.

Testing instructions

Same as #4393. You can also install another gateway (e.g., Square), create some subscriptions with it, and confirm that the notice is no longer shown when viewing those.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Aug 7, 2025
@wjrosa wjrosa marked this pull request as ready for review August 7, 2025 21:34
@wjrosa wjrosa requested review from a team, annemirasol and malithsen and removed request for a team August 7, 2025 22:16
Copy link
Contributor

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! 🚢

Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@wjrosa wjrosa added this to the 9.9.0 milestone Aug 8, 2025
@wjrosa wjrosa merged commit c16b463 into develop Aug 8, 2025
46 checks passed
@wjrosa wjrosa deleted the fix/checking-for-the-subscription-detached-payment-method branch August 8, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants