Skip to content

style: apply readability-braces-around-statements #8136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

style: apply readability-braces-around-statements #8136

wants to merge 1 commit into from

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Dec 24, 2024

Reference Issue

What does this implement/fix? Explain your changes.

rdkit/.clang-tidy

Line 2 in bebd2eb

Checks: '-*,boost-use-to-string,modernize-use-auto,modernize-use-nullptr,modernize-loop-convert,modernize-use-override,modernize-pass-by-value,modernize-shrink-to-fit,readability-braces-around-statements,readability-simplify-boolean-expr'

Any other comments?

@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 68f72fc to e328c57 Compare January 1, 2025 03:39
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 335f6d7 to 94c1368 Compare January 9, 2025 07:37
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 3 times, most recently from f47276d to 42807c9 Compare January 19, 2025 21:11
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 3ea80d3 to a8c96ac Compare January 31, 2025 09:15
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 108c2f6 to 5db99c0 Compare February 26, 2025 16:54
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 3c48dea to cb9df2b Compare March 8, 2025 04:44
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 67eb65e to 1760af2 Compare March 20, 2025 15:04
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 3 times, most recently from f4f91fa to 341db60 Compare April 1, 2025 06:24
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 341db60 to 1176f78 Compare April 2, 2025 04:53
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 1176f78 to 2aec4a3 Compare April 9, 2025 12:05
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 2aec4a3 to f79583b Compare April 17, 2025 01:20
greglandrum
greglandrum requested changes Apr 25, 2025
View reviewed changes
Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some files in here that shouldn't be, but everything else looks good.

Please remove the .cmake files

@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from f79583b to 1ae61cd Compare May 2, 2025 14:58
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from b9c1d52 to bb67895 Compare May 14, 2025 13:56
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 2947f00 to a1cd729 Compare May 24, 2025 12:14
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 1ebe265 to 745d7fd Compare June 1, 2025 23:37
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 745d7fd to d1a07d4 Compare June 6, 2025 19:45
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from d1a07d4 to 1c9400f Compare June 17, 2025 01:29
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from d7a3498 to 1a2da85 Compare July 3, 2025 06:51
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 1a2da85 to 171dd0f Compare July 8, 2025 04:25
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 4 times, most recently from 110c9a4 to 3b7ad43 Compare July 22, 2025 10:41
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 3b7ad43 to 38980fc Compare July 25, 2025 21:54
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 38980fc to f80ae0c Compare August 1, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglandrum greglandrum greglandrum requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-kwsm @greglandrum