Dagger Shell: Allow using flags for required args #10819
+141
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bce27a to
e5235b1
Compare
Attempt to solve dagger#9701 Signed-off-by: Jeremy Adams <jeremy@dagger.io>
Signed-off-by: Jeremy Adams <jeremy@dagger.io>
e5235b1 to
13de4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9701
With this PR you can use a flag for any arg (e.g.
--argname) including required args where previously Dagger Shell would strictly require a positional arg WITHOUT a flag. Use all the flags or just the ones you want for clarity.Any args without flags should act as positional args to fill in the remaining ordered positional slots.
more manual testing
docs after PR merged because we want to ship this, get feedback and incorporate into new docs
perhaps make error messages better regarding required/positional in a followup
perhaps more tests in a followup if needed
After merging this PR, will look at idea of autocompletion of flags