Skip to content

feat: Added WaitUntilTrue for basic boolean checks #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CpazR
Copy link

@CpazR CpazR commented May 1, 2024

Added shorthand that allows coroutines to conditionally wait on external properties and conditions.

See README changes for basic example.

@WeaverDev
Copy link
Owner

Thank you for the contribution, but I think the following pattern covers this use case:
while(!externalCondition) yield return Timing.WaitForOneFrame;
Is there a case I am missing?

@CpazR
Copy link
Author

CpazR commented May 20, 2024

Thank you for the contribution, but I think the following pattern covers this use case: while(!externalCondition) yield return Timing.WaitForOneFrame; Is there a case I am missing?

Not able to test this at the moment, but I would think you're correct?

Still wrapping my head around IEnumerables work, so it's likely this could be better optimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants