Skip to content

Assign unused parameters to placeholder to avoid too many warning in IDE #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

Assign unused parameters to placeholder to avoid too many warning in IDE #3684

merged 2 commits into from
Apr 24, 2025

Conversation

git-hulk
Copy link
Contributor

@git-hulk git-hulk commented Apr 24, 2025 •
edited
Loading

This closes #3348.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@git-hulk git-hulk changed the title Fix/issue 3348 Assign unused parameters to placeholder to avoid too many warning in IDE Apr 24, 2025
@coveralls
Copy link

Coverage Status

coverage: 73.021%. remained the same
when pulling d5e3052 on git-hulk:fix/issue-3348
into 4d37d2d on 99designs:master.

@git-hulk
Copy link
Contributor Author

The first commit d02b502 changed type.gotpl template and the second commit is generated by go generate.

@StevenACoffman
Copy link
Collaborator

Nice! Thanks for calling out the real change!

@StevenACoffman StevenACoffman merged commit e3b1289 into 99designs:master Apr 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused Variable in generated.go
3 participants
@git-hulk @coveralls @StevenACoffman