Skip to content

Update goquery to v1.10.3 to pass the nancy check #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2025
Merged

Update goquery to v1.10.3 to pass the nancy check #3658

merged 2 commits into from
Apr 12, 2025

Conversation

git-hulk
Copy link
Contributor

The security check has failed due to golang/golang.org/x/net:

pkg:golang/golang.org/x/net@v0.37.0
1 known vulnerabilities affecting installed version

@StevenACoffman
Copy link
Collaborator

StevenACoffman commented Apr 12, 2025 •
edited
Loading

Thanks! It looks like you will need to run:

go generate ./...

And you will probably need to update _examples/go.mod as well.

@coveralls
Copy link

coveralls commented Apr 12, 2025 •
edited
Loading

Coverage Status

coverage: 73.364%. remained the same
when pulling 032cd57 on git-hulk:update-goquery
into 8ffc885 on 99designs:master.

@git-hulk
Copy link
Contributor Author

Thanks! It looks like you will need to run:

go generate ./...

And you will probably need to update _examples/go.mod as well.

@StevenACoffman Thanks for your correction. The _examples's go.mod has been updated after running the go generate ./....

@StevenACoffman StevenACoffman merged commit 55536f4 into 99designs:master Apr 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-hulk @StevenACoffman @coveralls