Fix: Apollo FTv1 tracing doesn't wait for field resolver completion #3639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steve Coffman <StevenACoffman@users.noreply.github.com>
|
can we merge this asap? @StevenACoffman |
|
Thanks for the ping! I hadn't noticed you had corrected updated it since the defer comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in Apollo Federation Tracing (FTv1) where the
EndTimeof a field span was recorded too early — before the field resolver had actually completed execution. This resulted in inaccurate tracing data, as the span duration didn't reflect the true time spent resolving the field.