Skip to content

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Mar 31, 2025

  • Enable revive.use-any and fix exclusions rules for use-any to ignore some generated files that should use interface{} and not any (rule text changed from 'use-any: since GO 1.18 'interface{}' can be replaced by 'any' to 'use-any: since Go 1.18 'interface{}' can be replaced by 'any')
  • Remove not relevant //nolint:deadcode because deadcode linter was removed in golangci-lint v2.

@coveralls
Copy link

Coverage Status

coverage: 73.343% (+0.06%) from 73.285%
when pulling 3b3c0e3 on alexandear:chore/reenable-revive-use-any
into 43a809b on 99designs:master.

@StevenACoffman
Copy link
Collaborator

Oh wow, Thanks!

At some point I really need to figure out why we are still generating some interface{} instead of all any

@StevenACoffman StevenACoffman merged commit 5babde5 into 99designs:master Mar 31, 2025
17 checks passed
@alexandear alexandear deleted the chore/reenable-revive-use-any branch March 31, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants