Revert default response header to application/json from #3555 #3615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Coffman <steve@khanacademy.org>
8a1e47a to
ccf4551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3555 we wanted gqlgen to accept
application/graphql-response+jsonas but not to make it the default when noAcceptheader was specified. This partially reverts that change so thatapplication/jsonis once more the default response mime type when noAcceptheader has been sent by the client.https://graphql.github.io/graphql-over-http/draft/
GraphQL over HTTP is Draft status.
but many clients appear to support this.
for example, apollo client switch Accept header default to application/graphql-response+json.
apollographql/apollo-client#12206
Apollo Client 4.0 will be shipped at Mid April 2025
https://github.com/apollographql/apollo-client/blob/main/ROADMAP.md
Signed-off-by: Steve Coffman steve@khanacademy.org