Skip to content

Simplify creation of temporary creds #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

Simplify creation of temporary creds #1120

merged 1 commit into from
Feb 3, 2023

Conversation

mtibben
Copy link
Member

@mtibben mtibben commented Feb 3, 2023

Refactor tempCredsCreator, which was a particularly tricky part of the code to understand. This should make the logic much simpler to understand

on master:

$ gocyclo vault/vault.go
19 vault (*tempCredsCreator).provider vault/vault.go:204:1

on this branch:

$ gocyclo vault/vault.go
8 vault (*tempCredsCreator).GetProviderForProfile vault/vault.go:223:1
4 vault (*tempCredsCreator).getSourceCreds vault/vault.go:204:1

@mtibben mtibben merged commit ee40d15 into master Feb 3, 2023
@mtibben mtibben deleted the simplify-temp-creds-creator branch February 3, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtibben