Recreate OIDC token when 401 error is returned #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtibben
reviewed
Nov 22, 2022
| @@ -66,6 +69,23 @@ func (p *SSORoleCredentialsProvider) getRoleCredentials(ctx context.Context) (*s | |||
| RoleName: aws.String(p.RoleName), | |||
| }) | |||
| if err != nil { | |||
| if cached && p.OIDCTokenCache != nil { | |||
There was a problem hiding this comment.
there's a possibility that a token is invalidated between the time that it's created, so I wonder if checking cached is necessary at all
There was a problem hiding this comment.
Checking cached ensures getRoleCredentials won't be stuck in an infinite recursion loop if some AWS bug was to cause CreateToken to return invalid or expired tokens. In these rare situations, I thought it would be safer to return an error immediately instead of possibly retrying forever.
|
Thanks @cezarsa |
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally AWS returns 401 unauthorized errors on
GetRoleCredentialswith OIDC tokens that shouldn't have expired yet according to the expiration date returned by AWS. The error message in these situations looks like this:When this happened the only solution was to run
aws-vault clear.This error has occurred in the past when AWS returned the wrong expiration date for some time (#854 and #722) and it still happens occasionally to some users, I guess that's due to AWS invalidating tokens on some situations for security reasons.
This PR adds the ability for aws-vault to detect when a 401 error is returned, clear the cached OIDC token and retry the operation once with a new OIDC token.