Skip to content

Conversation

fw42
Copy link
Contributor

@fw42 fw42 commented Mar 28, 2025

Not sure if this was intentional but seems like a bug.

@8398a7

@8398a7
Copy link
Owner

8398a7 commented Mar 28, 2025

I fixed the issue in master that was causing the test to fail. Can you incorporate that fix?

@fw42 fw42 force-pushed the fix-missing-as-author-space branch from 5a257f2 to 9f162ae Compare March 28, 2025 12:11
@fw42
Copy link
Contributor Author

fw42 commented Mar 28, 2025

Just rebased my branch

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ce4716a) to head (564f3f6).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          254       254           
  Branches        82        80    -2     
=========================================
  Hits           254       254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@8398a7 8398a7 merged commit 87071b5 into 8398a7:master Mar 28, 2025
8 checks passed
@fw42 fw42 deleted the fix-missing-as-author-space branch March 28, 2025 13:36
@fw42
Copy link
Contributor Author

fw42 commented Mar 28, 2025

Thanks for the quick turnaround!

joshbode pushed a commit to joshbode/action-slack that referenced this pull request Jul 17, 2025
* Add missing space to AS_AUTHOR between name and email

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants