Avoid changing global config #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@74th please take a look. |
|
We want the changes to persist for the entire shell session. Wouldn't the context manager undo them at the end of the function? Edit: Nevermind, it just undoes the |
con-f-use
approved these changes
Aug 22, 2024
|
@anki-code Thanks for finding and PR-ing. Please bump the patch version and add a release note to README.md |
|
Thank you for review @con-f-use !
Done.
It returns UPDATE_OS_ENVIRON to the previous state. It's the right pattern. |
74th
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Instead of changing global config (it's bad pattern) I suggest to wrap your changes into the context manager.