Skip to content

[Issue#291]updating algorithm to use RFC1951 rather than RFC1950 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2022
Merged

[Issue#291]updating algorithm to use RFC1951 rather than RFC1950 #292

merged 3 commits into from
Apr 29, 2022

Conversation

feliperoos
Copy link
Contributor

This intends to fix Issue #291 as it has surfaced during tests we've been doing.
I'll add more details after I can test it properly, then I'll change PR status to final.

@feliperoos feliperoos self-assigned this Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022 •
edited
Loading

Codecov Report

Merging #292 (9bb0d8c) into develop (30d5c2e) will increase coverage by 2.67%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #292      +/-   ##
===========================================
+ Coverage    72.83%   75.50%   +2.67%     
===========================================
  Files          418      419       +1     
  Lines        23280    28406    +5126     
===========================================
+ Hits         16955    21447    +4492     
- Misses        6325     6959     +634
Impacted Files Coverage Δ
...ce/Common/Platform/NMR_ExportStream_Compressed.cpp 65.85% <100.00%> (ø)
...ce/Common/Platform/NMR_ImportStream_Compressed.cpp 69.64% <100.00%> (+0.55%) ⬆️
Source/API/lib3mf_multipropertygroup.cpp 76.81% <0.00%> (-2.85%) ⬇️
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp 93.47% <0.00%> (-1.52%) ⬇️
Source/Model/Classes/NMR_ModelSliceStack.cpp 84.46% <0.00%> (-0.06%) ⬇️
Include/API/lib3mf_reader.hpp 100.00% <0.00%> (ø)
Include/API/lib3mf_writer.hpp 100.00% <0.00%> (ø)
Autogenerated/Source/lib3mf_interfaces.hpp 100.00% <0.00%> (ø)
Autogenerated/Source/lib3mf_types.hpp 19.56% <0.00%> (ø)
Source/API/lib3mf_writer.cpp 79.85% <0.00%> (+0.01%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d5c2e...9bb0d8c. Read the comment docs.

@martinweismann martinweismann changed the base branch from master to develop March 21, 2022 07:56
jordig100
jordig100 reviewed Mar 21, 2022
View reviewed changes
Copy link

@jordig100 jordig100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@feliperoos
Copy link
Contributor Author

There's a few tests failing, I still haven't gone through them.

@martinweismann martinweismann marked this pull request as ready for review April 29, 2022 13:27
@martinweismann martinweismann merged commit 58af444 into develop Apr 29, 2022
@martinweismann martinweismann deleted the hotfix_issue_291 branch April 29, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordig100 jordig100 jordig100 left review comments

@alexanderoster alexanderoster Awaiting requested review from alexanderoster

@martinweismann martinweismann Awaiting requested review from martinweismann

Assignees

@feliperoos feliperoos

Labels
bug secure content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feliperoos @jordig100 @martinweismann