-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Description
@2dust Hello!
As I mentioned in #5829 the current default routing rules are useless for regions outside of China. To solve this problem, I suggest making support for “presets” for different regions based on the OS language.
What I mean is that when we initialize the default settings when we first start the program, we can automatically set parameters like program language, source of geo files and source of routing rule templates based on OS language. I am sure this will be useful at least for people from Russia and Iran. Maybe if the language is set to English we could show a window asking which preset to use from several options - China, Iran, Russia and Other.
So that's what I propose to do:
- Support for external sources of routing rule templates (let the default rule set also be provided inside the program).
- Support for presets that will just change other configuration options (alternatively just do it once on first run).
- Based on the preset, set the application language (only on first run), source of geo files and source of routing rule templates.
- At the first startup, ask the user which preset they would like to use in case we don't know where it comes from (not sure if this is necessary).
As for sources of routing rule templates, for Russia it would be great to use dynamic loading rules from github repository, as jsdelivr would be difficult to block in Russia, as it is used by a huge number of sites.
I'm ready to do it myself and submit a PR, but first I'd like to hear your opinion on whether you're ok with it.
Thank you!