Skip to content

Add test for testutil.TestNewTestChain() with options #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Add test for testutil.TestNewTestChain() with options #278

merged 1 commit into from
Aug 7, 2025
+17 −0

Conversation

VojtechVitek
Copy link
Contributor

@VojtechVitek VojtechVitek commented Aug 7, 2025 •
edited
Loading

Add test for this error I encountered in the stack/api repo:

# github.com/0xsequence/go-sequence/testutil
../../../../go/pkg/mod/github.com/0xsequence/go-sequence@v0.55.0/testutil/testutil.go:91:51:
   cannot use logger.NewLogger(logger.LogLevel_INFO) (value of interface type logger.Logger) as *slog.Logger value in argument to ethreceipts.NewReceiptsListener

Unfortunately, I think this won't prove/fix the root cause -- I think I'll need to upgrade ethkit.

@VojtechVitek
Copy link
Contributor Author

Following up in #279

shunkakinoki
shunkakinoki approved these changes Aug 7, 2025
View reviewed changes
Copy link

@shunkakinoki shunkakinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@VojtechVitek VojtechVitek merged commit 6c22c04 into master Aug 7, 2025
1 check passed
@VojtechVitek VojtechVitek deleted the add-test-for-testutil-testnewtestchain-w branch August 7, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunkakinoki shunkakinoki shunkakinoki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VojtechVitek @shunkakinoki