Skip to content

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Apr 3, 2023

make build and lint should automatically format go files with gofumpt

@0xERR0R 0xERR0R added this to the v0.22 milestone Apr 3, 2023
@0xERR0R 0xERR0R added the 🧰 technical debts Technical debts, refactoring label Apr 3, 2023
@0xERR0R 0xERR0R marked this pull request as ready for review April 3, 2023 14:44
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (68a8476) 93.53% compared to head (a3b58e7) 93.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   93.53%   93.47%   -0.06%     
==========================================
  Files          63       63              
  Lines        5320     5320              
==========================================
- Hits         4976     4973       -3     
- Misses        269      271       +2     
- Partials       75       76       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@kwitsch kwitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usefull change 👍

@0xERR0R 0xERR0R merged commit 74fcd50 into main Apr 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the makefile-fmt branch April 4, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants