Skip to content

Conversation

FileGo
Copy link
Collaborator

@FileGo FileGo commented May 24, 2022

This fixes #533 to remove functionality, deprecated in Go 1.18.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #536 (14c68cc) into development (8d0bd8e) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development     #536   +/-   ##
============================================
  Coverage        93.73%   93.73%           
============================================
  Files               36       36           
  Lines             3112     3112           
============================================
  Hits              2917     2917           
  Misses             145      145           
  Partials            50       50           
Impacted Files Coverage Δ
lists/downloader.go 100.00% <100.00%> (ø)
resolver/upstream_resolver.go 91.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0bd8e...14c68cc. Read the comment docs.

@FileGo FileGo mentioned this pull request May 25, 2022
@0xERR0R
Copy link
Owner

0xERR0R commented May 27, 2022

Thanks!

@0xERR0R 0xERR0R added the 🧰 technical debts Technical debts, refactoring label May 27, 2022
@0xERR0R 0xERR0R added this to the 0.19 milestone May 27, 2022
@0xERR0R 0xERR0R merged commit 8bb4f73 into 0xERR0R:development May 27, 2022
@FileGo FileGo deleted the go1.18-net-temporary branch May 29, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.18 deprecation of net.Error.Temporary()
2 participants