Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: 0vercl0k/udmp-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1
Choose a base ref
...
head repository: 0vercl0k/udmp-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Dec 12, 2022

  1. Move the includes out of the namespace (#4) 

    This causes `unistd`'s functions, etc. to be in the `udmpparser` namespace which causes issues on OSX in one other project I am working on:
```
utils.cc:597:26: error: use of undeclared identifier 'readlink'; did you mean 'udmpparser::readlink'?
  const ssize_t Length = readlink("/proc/self/exe", ExePathBuffer.data(),
                         ^~~~~~~~
                         udmpparser::readlink
/Applications/Xcode_14.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/unistd.h:627:10: note: 'udmpparser::readlink' declared here
ssize_t  readlink(const char * __restrict, char * __restrict, size_t);
         ^
1 error generated.
```

It also updates / fixes the CI.
    @0vercl0k
    0vercl0k authored Dec 12, 2022
    Configuration menu
    Copy the full SHA
    ddf3417 View commit details
    Browse the repository at this point in the history
Loading