Add fallback behavior for os.getlogin() raising No such device or address
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… No such device or address` Apparently the behavior is depending on the environment, see here: https://bugs.python.org/issue40821 Instead I made the fan world-writable, which might not be the best security wise, but it probably good enough.
|
Thank you for this LGTM, was not aware of this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallback behavior for
os.getlogin()raisingNo such device or addressApparently the behavior is depending on the environment, see here: https://bugs.python.org/issue40821
Instead I made the fan world-writable, which might not be the best security wise, but it probably good enough. Now it works for me™