Regex fix for issue #5 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Yes would probably be better, I don't think performance is an issue here, but I personally would leave it as is for now and revisit the json parsing when I do my fan curve implementation, since then I will need a better CPU temp reading anyway. Currently the CPU temp display is more or less gimmicky anyway as it does not actually do anything regarding the fan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a couple of issues with the updated regex from the last PR.
I've updated it to fix issue #5 and it should catch some other edge cases as well
Confirmed fix for provided output on #5:
A better fix may be to use
getTempInfo_jsoninstead, then there doesn't have to be any regex involved, you just have to iterate through the devices and then its sensors to see which device has a sensor labelled "CPU", and filter zeroed values or such like.I'm not sure if the slight performance hit from having to process json will make any difference or not. If you would like me to submit a PR for that I could.