Skip to content

fix: add checks for incorrect behavior in Uint8Array.fromBase64, setFromBase64, and toBase64 methods #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2025
Merged

fix: add checks for incorrect behavior in Uint8Array.fromBase64, setFromBase64, and toBase64 methods #1441

merged 2 commits into from
Jun 29, 2025

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Jun 29, 2025

fixes #1439

@brc-dd

This comment was marked as outdated.

Sign in to view
@zloirock
Copy link
Owner

zloirock commented Jun 29, 2025 •
edited
Loading

Could you add tests to tests/unit-global and tests/compat (including toHex)? Flag, shebang, etc. are not required - it can be tested locally by manually enabling this flag in a browser.

@brc-dd
Copy link
Contributor Author

brc-dd commented Jun 29, 2025 •
edited
Loading

The existing tests in tests/unit-global were failing without this PR (with flag).

core-js/tests/unit-global/esnext.uint8-array.from-base64.js

Lines 36 to 37 in 7ce47e8

assert.throws(() => fromBase64('SGVsbG8gV29ybGQ1=', null), TypeError, 'incorrect options argument #1');
assert.throws(() => fromBase64('SGVsbG8gV29ybGQ1=', 1), TypeError, 'incorrect options argument #2');

core-js/tests/unit-global/esnext.uint8-array.to-base64.js

Lines 18 to 19 in 7ce47e8

assert.throws(() => array.toBase64(null), TypeError, 'incorrect options argument #1');
assert.throws(() => array.toBase64(1), TypeError, 'incorrect options argument #2');

Looking into tests/compat...

@brc-dd
Copy link
Contributor Author

brc-dd commented Jun 29, 2025 •
edited
Loading

image

(left to right - safari 18.5, firefox 141.0b3, chromium 138.0.7204.50)

image

@zloirock
Copy link
Owner

Thanks.

@zloirock zloirock merged commit 892474c into zloirock:master Jun 29, 2025
23 checks passed
@brc-dd brc-dd deleted the fix/1439-2 branch June 30, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zloirock zloirock zloirock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for broken implementation of Uint8Array.prototype.toHex
2 participants
@brc-dd @zloirock